Skip to content

infra: fix for benchmark CI #4723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xrmx merged 10 commits into from
Aug 18, 2025
Merged

infra: fix for benchmark CI #4723

xrmx merged 10 commits into from
Aug 18, 2025

Conversation

@emdneto
Copy link
Member

@emdneto emdneto commented Aug 15, 2025 •
edited
Loading

@emdneto emdneto requested a review from a team as a code owner August 15, 2025 02:18
emdneto
emdneto commented Aug 15, 2025
View reviewed changes
Copy link
Member Author

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trask we recently changed the runner for benchmark to use the runner oracle-bare-metal-64cpu-512gb-x86-64, but CI is saying there's no space left on the disk. Are we doing something wrong here?

@trask
Copy link
Member

trask commented Aug 15, 2025

I think this is fixed now: open-telemetry/community#2927

it's now failing for a different reason, similar to Java: open-telemetry/opentelemetry-java#7578

@emdneto
Copy link
Member Author

emdneto commented Aug 15, 2025

I think this is fixed now: open-telemetry/community#2927

it's now failing for a different reason, similar to Java: open-telemetry/opentelemetry-java#7578

Thank you for the quick fix. Will try Let's see if it works now

@emdneto emdneto added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Aug 15, 2025
@emdneto emdneto changed the title Update benchmarks.yml infra: fix for benchmark CI Aug 15, 2025
aabmass
aabmass approved these changes Aug 15, 2025
View reviewed changes
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR still needed after Trasks's comment or was that regarding a previous failure?

@emdneto
Copy link
Member Author

emdneto commented Aug 18, 2025

Is this PR still needed after Trasks's comment or was that regarding a previous failure?

@aabmass Yes. It's failing in the main branch because the setup-python action is not working on this runner.

@xrmx xrmx merged commit fe0a074 into main Aug 18, 2025
738 of 739 checks passed
@xrmx xrmx deleted the emdneto-patch-5 branch August 18, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xrmx xrmx xrmx approved these changes

@aabmass aabmass aabmass approved these changes

Assignees

No one assigned

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@emdneto @trask @xrmx @aabmass